add targets vulkan1.3, vulkan1.4 and spv1.6
#271
Conversation
Firestar99
force-pushed
the
vulkan1_4
branch
4 times, most recently
from
9201ba7 to
5629a2c
Compare
|
Compiletest fails due to the installed tools being too old and not knowing what Current CI downloads a pre-build version of spirv tools from Embark's spirv-tools repo, specifically release 0.10.0, which includes some pre-build Some Options we have to fix this:
I'm considering trying out 2 tomorrow, or do you @LegNeato have a better idea? This also unblocks #258 |
|
@LegNeato This is effectively ready to review, it just requires #279 and spirv-tools-rs PR Rust-GPU/spirv-tools-rs#11 to be merged and released on crates. |
Firestar99
force-pushed
the
vulkan1_4
branch
3 times, most recently
from
b9e1d6d to
b544bcc
Compare
.github/workflows/ci.yaml
Outdated
| @@ -151,7 +151,7 @@ jobs: | |||
| - name: cargo fetch --locked | |||
| run: cargo fetch --locked --target ${{ matrix.target }} | |||
| - name: compiletest | |||
| run: cargo run -p compiletests --release --no-default-features --features "use-installed-tools" -- --target-env vulkan1.1,vulkan1.2,spv1.3 | |||
| run: cargo run -p compiletests --release --no-default-features --features "use-installed-tools" -- --target-env vulkan1.1,vulkan1.2,vulkan1.3,vulkan1.4 | |||
There was a problem hiding this comment.
I am not sure I understand the ramifications of changing this so I'll just trust you
There was a problem hiding this comment.
yea, I should add spv1.3 back for the weird quad texture tests, though I think in practice everyone uses vulkan targets anyway
Requires #279, Rust-GPU/spirv-tools-rs#11
I thought it'll be easy going, but it seems like spv1.6 introduced some new validation we're now failing.Nope, just some tests excluded for vulkan that need their target list extended.