Skip to content

Conversation

newpavlov
Copy link
Member

The check was too conservative and caused false negatives on some targets. This change follows the is_x86_feature_detected! macro (see: https://docs.rs/crate/std_detect/latest/source/src/detect/os/x86.rs).

Closes #1129

@newpavlov newpavlov requested a review from tarcieri November 11, 2024 15:57
@newpavlov newpavlov merged commit 32842f6 into master Nov 11, 2024
94 checks passed
@newpavlov newpavlov deleted the xmm_xsave branch November 11, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cpufeatures: PCLMULQDQ does not require OSXSAVE

1 participant