fix: Dynamic log group support in IAM execution role policy #260
+15
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes hardcoded log group in AWS IAM execution role policy that prevented using custom log groups with Fargate deployments. Changes: - Add log_group parameter to get_execution_role_arn() function - Dynamically generate IAM policy with user-specified log group - Remove unused secretsmanager:GetSecretValue permission This allows users to specify custom CloudWatch log groups via FargateDeploymentConfig.log_group and ensures the execution role has appropriate permissions for the configured log group.
Member
|
For this one I have to defer to @carlosejimenez , I'm not knowledgeable enough about AWS |
Contributor
Author
|
@carlosejimenez when available, can you take a look? |
Contributor
Author
|
@klieret @carlosejimenez any thoughts on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hardcoded log group in AWS IAM execution role policy that prevented using custom log groups with Fargate deployments.
Changes:
This allows users to specify custom CloudWatch log groups via FargateDeploymentConfig.log_group and ensures the execution role has appropriate permissions for the configured log group.
Note: This change removes the secretsManager. It is unclear on what its intended usage was previously, as the policy has a mixed SecretManager action with Cloudwatch resources and would never match