Skip to content

[SYNPY-1483] Update default order for credential provider #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

BryanFauble
Copy link
Member

Problem:

  1. There have been 2 service desk tickets from folks unable to use synapse login -p $AUTH_TOKEN due to having a synapse config that might not have the appropriate data.

Solution:

  1. Updating the credential chain to use CLI arguments first

Testing:

  1. Verified that setting -p is used if supplied, but not if not supplied:
    image

@BryanFauble BryanFauble requested a review from a team as a code owner June 7, 2024 18:54
@pep8speaks
Copy link

Hello @BryanFauble! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 212:89: E501 line too long (116 > 88 characters)
Line 213:89: E501 line too long (120 > 88 characters)

Copy link
Contributor

@rxu17 rxu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BryanFauble BryanFauble merged commit 15d121b into develop Jun 7, 2024
17 checks passed
@BryanFauble BryanFauble deleted the SYNPY-1483-update-credential-chain branch June 7, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants