-
-
Notifications
You must be signed in to change notification settings - Fork 227
Added PDIRK and PRK solvers #2303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Where are the tests for these ones? |
I didn't see a separate file of tests for these ones but the tests are there in ode_convergence_tests.jl. The convergence test function for PDIRK44 is present inside Implicit Solver Convergence Tests and tests for KuttaPRK2p5 are present in Explicit Solver Convergence Tests |
@ChrisRackauckas any changes to be made in the tests for these solvers ?? |
@oscardssmith https://github.com/SciML/OrdinaryDiffEq.jl/actions/runs/10157523456/job/28087785439?pr=2303#step:6:658 if we don't find a fix soon we'll need to revert the StaticArray change |
investigating now. |
From initial inspection, this doesn't seem related to my changes since it is happening in |
It's the ArrayInterface.jl changes. |
the ArrayInterface change shouldn't have changed anything here... RecursiveArrayTools depends on StaticArrays unconditionally, and StaticArrays has been loaded, so the extension should still be running... |
Ah, the problem is that
|
problem found. Partial revert incoming. |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.
solves a part of #2177