Skip to content

Added PDIRK and PRK solvers #2303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 30, 2024
Merged

Conversation

ParamThakkar123
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.
solves a part of #2177

@ParamThakkar123 ParamThakkar123 mentioned this pull request Jul 28, 2024
5 tasks
@ChrisRackauckas
Copy link
Member

Where are the tests for these ones?

@ParamThakkar123
Copy link
Contributor Author

Where are the tests for these ones?

I didn't see a separate file of tests for these ones but the tests are there in ode_convergence_tests.jl. The convergence test function for PDIRK44 is present inside Implicit Solver Convergence Tests and tests for KuttaPRK2p5 are present in Explicit Solver Convergence Tests

@ParamThakkar123
Copy link
Contributor Author

@ChrisRackauckas any changes to be made in the tests for these solvers ??

@ChrisRackauckas
Copy link
Member

There is a test failure https://github.com/SciML/OrdinaryDiffEq.jl/actions/runs/10133887447/job/28019521857?pr=2303#step:6:953

@ChrisRackauckas
Copy link
Member

@oscardssmith https://github.com/SciML/OrdinaryDiffEq.jl/actions/runs/10157523456/job/28087785439?pr=2303#step:6:658 if we don't find a fix soon we'll need to revert the StaticArray change

@ChrisRackauckas ChrisRackauckas merged commit a6005a1 into SciML:master Jul 30, 2024
37 of 40 checks passed
@oscardssmith
Copy link
Member

investigating now.

@oscardssmith
Copy link
Member

From initial inspection, this doesn't seem related to my changes since it is happening in addsteps! which is pretty far away in the code from anything with the jacobians...

@ChrisRackauckas
Copy link
Member

It's the ArrayInterface.jl changes.

@oscardssmith
Copy link
Member

oscardssmith commented Jul 30, 2024

the ArrayInterface change shouldn't have changed anything here... RecursiveArrayTools depends on StaticArrays unconditionally, and StaticArrays has been loaded, so the extension should still be running...

@oscardssmith
Copy link
Member

Ah, the problem is that ArrayInterface.ismutable is a generated function that illegally depends on world age I think.

>121  @generated function ArrayInterface.ismutable(::Type{<:ArrayPartition{T, S}}) where {T, S
 122  }
 123      res = all(ArrayInterface.ismutable, S.parameters)
 124      return :($res)
 125  end

@oscardssmith
Copy link
Member

problem found. Partial revert incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants