v4 of upload and download artifact

[HGWright]

🚀 Pull Request

Description

#180 and #181 are failing, I believe because they are reliant on each other. Hopefully puttting the changes in a single PR should fix the CI failure.

---

[pp-mo]

I think this won't work if any GHA server produces more than one wheel, since different wheels can produce artifacts of the same name, and the v4 upload now disallows over-writing of an existing named artifact.
See notes here

[HGWright]

I think this would still fail if it was attempting to pushing to test-pypi and pypi, so i will try and sort that out before you merge this

[HGWright]

I think this would still fail if it was attempting to pushing to test-pypi and pypi, so i will try and sort that out before you merge this

on second thoughts, i'm not so sure that this would fail those steps. @pp-mo I think this is mergable and if it does fail pushing to pypi and test-pypi going forwards at least we know where that is coming from

[pp-mo]

There are still some aspects of how the naming works, and what gets uploaded that I don't quite follow - i.e. how does pypa/gh-action-pypi-publish actually know what files to take, and how do the wheels uploaded into /wheelhouse get downloaded into /dist with the sdist.

But it does look reasonable by comparison with what we had before,
so I agree that the easiest approach now is just to merge it + see what happens !