Skip to content

Conversation

@HGWright
Copy link
Contributor

🚀 Pull Request

Description


After the failing CI for #238 and #239. We found that we need to do numpy.import_array() when doing cimport numpy as np.

https://numpy.org/doc/stable/reference/c-api/array.html#c.import_array

@HGWright HGWright requested a review from bjlittle June 27, 2024 14:26
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HGWright Yup, looks good to me.

Nice one for unblocking this 👍

@bjlittle bjlittle merged commit f7e72e1 into SciTools:main Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants