Skip to content

Conversation

@HGWright
Copy link
Contributor

🚀 Pull Request

Description


@HGWright
Copy link
Contributor Author

HGWright commented Sep 27, 2024

@trexfeathers Two things about this:

  1. Im a bit confused why this check is expected (could it be a handover of when that did run in this PR) but i still don't expect this.
  2. Had to do force push for conflicts, I think because this used to have a file that did not exist locally (py39 lockfile).

@trexfeathers
Copy link
Contributor

trexfeathers commented Nov 7, 2024

GitHub auto-merge must have 'required checks' in the branch protection rules. It looks like you (or maybe @bjlittle?) selected the following to be required (minus the CLA, which I selected):

This might mean we want to adjust our testing naming somehow so this doesn't become a problem every time we switch Python versions?

image

@trexfeathers trexfeathers merged commit a85ef50 into SciTools:main Nov 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants