Skip to content

Enabling a Dynamic Grid #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 9, 2020
Merged

Enabling a Dynamic Grid #1125

merged 6 commits into from
Oct 9, 2020

Conversation

diemol
Copy link
Member

@diemol diemol commented Oct 9, 2020

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Allowing docker-selenium to behave as a dynamic Grid, where containers are created in the
background as new session requests come in.

Motivation and Context

This will allow users to simplify their Grid deployments.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@diemol diemol marked this pull request as draft October 9, 2020 14:22
@diemol diemol marked this pull request as ready for review October 9, 2020 22:29
@diemol diemol merged commit 297b387 into trunk Oct 9, 2020
@diemol diemol deleted the docker-alongside-docker branch October 9, 2020 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant