Skip to content

Simplyfing config for Dynamic Grid #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 8, 2020
Merged

Simplyfing config for Dynamic Grid #1158

merged 3 commits into from
Dec 8, 2020

Conversation

diemol
Copy link
Member

@diemol diemol commented Dec 8, 2020

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Until now, the user had to describe through the config.toml file the paths to be used inside the container and on the host. This could be error-prone. Now, we inspect the container and identify the host path mounted to /opt/selenium/assets, and then use that path to mount it on the video container.

Motivation and Context

Simplifies the configuration for Dynamic Grid, making it less error prone.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@diemol diemol merged commit a667620 into trunk Dec 8, 2020
@diemol diemol deleted the simplify-config branch December 8, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant