Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Only merge after Selenium Grid 4.1.1 has been released
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Adding SE_BIND_HOST as an env var, by default set to false to be used when the Grid server is started.
Motivation and Context
A recent change in the Grid server corrected how the server binds to the host and port, which honors when a user sets the
host
value as a parameter. However, this change broke a few things in environments like Docker, because normally one wants to sethost
as the IP or hostname of the machine where the containers are running, and the server cannot bind to that IP from inside the container. Now, the new flag allows to set a host but not necessarily bind to it, when it is set to false.Fixes #1453
Types of changes
Checklist