Skip to content

Fixing issue #1453 #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Fixing issue #1453 #1467

merged 2 commits into from
Dec 17, 2021

Conversation

diemol
Copy link
Member

@diemol diemol commented Dec 15, 2021

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Only merge after Selenium Grid 4.1.1 has been released

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Adding SE_BIND_HOST as an env var, by default set to false to be used when the Grid server is started.

Motivation and Context

A recent change in the Grid server corrected how the server binds to the host and port, which honors when a user sets the host value as a parameter. However, this change broke a few things in environments like Docker, because normally one wants to set host as the IP or hostname of the machine where the containers are running, and the server cannot bind to that IP from inside the container. Now, the new flag allows to set a host but not necessarily bind to it, when it is set to false.

Fixes #1453

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@diemol diemol merged commit 5009ac3 into trunk Dec 17, 2021
@diemol diemol deleted the bind-host branch December 17, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Port ____ already In use with selenium/node-chrome:4.1.0-20211123
1 participant