Workaround to mount docker.sock #1505
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
This PR enables users to mount
docker.sock
for the Dynamic Grid. It is usingsudo
andsocat
under the hood, so it is not ideal, but it was the path with the least amount of changes. It is expected to present issues in some restricted environments (nosudo
allowed), but the idea is to iterate on the feature.Fixes #1430
Motivation and Context
Some users cannot configurate in a simple way tcp for docker, so this is a way to simplify usage,
Types of changes
Checklist