Skip to content

Selenium Grid Helm Chart #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Feb 24, 2022
Merged

Selenium Grid Helm Chart #1508

merged 25 commits into from
Feb 24, 2022

Conversation

ilpianista
Copy link
Contributor

Add an Helm Chart to deploy Selenium Grid.

Description

Continuation of @pedrodotmc's work in #1184 to support an Helm Chart to deploy Selenium Grid.

Motivation and Context

Easily deploy Selenium Grid on Kubernetes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ilpianista ilpianista changed the title Selenium grid helm chart 0.3.0 Selenium Grid Helm Chart Feb 10, 2022
@CLAassistant
Copy link

CLAassistant commented Feb 10, 2022

CLA assistant check
All committers have signed the CLA.

@tgupta-adc
Copy link

When can we expect it to get merged? My team has been waiting for it.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @ilpianista!

I left a small suggestion.

Do you know how we could test this in GitHub Actions?

I messaged @pedrodotmc in Slack and Twitter. I think we really need them to sign the CLA to accept the contribution. Will wait a bit until they reply.

@diemol
Copy link
Member

diemol commented Feb 20, 2022

Also, @ilpianista, would you have time to help us triage issues related to the Helm chart? And eventually join the project?

@ilpianista
Copy link
Contributor Author

Also, @ilpianista, would you have time to help us triage issues related to the Helm chart? And eventually join the project?

We are using this Helm in my company and thus we are interested in fixing any bug that affects it. I don't know about adding new features though because that depends exclusively on my free time.

@pedromctech
Copy link
Contributor

I just signed the CLA. Sorry for the delay, thanks @ilpianista for making this possible!

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ilpianista and @pedrodotmc!

@diemol
Copy link
Member

diemol commented Feb 24, 2022

Also, @ilpianista, would you have time to help us triage issues related to the Helm chart? And eventually join the project?

We are using this Helm in my company and thus we are interested in fixing any bug that affects it. I don't know about adding new features though because that depends exclusively on my free time.

@ilpianista any chance you can join our Slack/IRC/Matrix channel so we can coordinate? Links can be seen here https://www.selenium.dev/support/

@diemol diemol merged commit fe28e0c into SeleniumHQ:trunk Feb 24, 2022
@diemol diemol mentioned this pull request Feb 24, 2022
@ilpianista ilpianista deleted the selenium-grid-helm-chart-0.3.0 branch March 31, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants