Add libnss3-tools installation to chrome and edge image

[algoritmus]

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Added libnss3-tools package to image in order to be able to add custom certificates, WAs, etc to nssdb, or be able to create new nssdb. Nssdb certificate storage is used by chromium based browsers (Chrome, Edge)

Motivation and Context

In order to be able to add custom certificates, WAs, etc to nssdb, or be able to create new nssdb. Nssdb certificate storage is used by chromium based browsers (Chrome, Edge)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• [ x] New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[CLAassistant]

All committers have signed the CLA.

[diemol]

Changes to Nodes should be applied to this file https://github.com/SeleniumHQ/docker-selenium/blob/trunk/NodeBase/Dockerfile.txt

[algoritmus]

Corrected

[diemol]

Still missing docs showing how to use the feature. Could you please add them to the README?

[algoritmus]

Added usage to readme

[algoritmus]

The point would be that usually companies allows no access to external repos, so cannot do the install part of the libnss3. It is usually allows to get docker images but cannot do any apt-get. Ok, frankly speaking here I am a bit selfish, and this would help me, rather create an image at home with libnss install then use that image to add certs within enterprise environment. Feel free to reject the PR if you think it would serve too narrow user base. Attila

…

On Wed, 11 May 2022 at 11:13 Diego Molina ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In README.md <#1567 (comment)> : > +```bash +FROM selenium/node-edge:latest + +USER root + +COPY certs/ /etc/certs # copy over the certificate file + +RUN mkdir -p -m755 /home/seluser/.pki/nssdb \ #create nssdb folder + && certutil -d sql:/home/seluser/.pki/nssdb -N --empty-password \ # create new db without password + && certutil -d sql:/home/seluser/.pki/nssdb -A -t "C,," -n companyca -i /etc/certs/companeca.pem \ #trust company CA + && pk12util -d sql:/home/seluser/.pki/nssdb -i client_cert.p12 -W password_of_clent_cert # client certificate install + +``` +This way the certificates will be installed and the node will start automatically as before. + +___ + Apologies if I am being too exhaustive in the review, but if a user needs to create their own image to install the certificates, what is the benefit of installing the tools beforehand? This PR could be only adding this example to the documentation, and showing how the tools can be installed. Am I missing something? — Reply to this email directly, view it on GitHub <#1567 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADK3FFYGVHFZTDJREH4H5L3VJN23DANCNFSM5VOJ7VPA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[diemol]

@algoritmus thanks for being open about it. I am not sure if it is a common use case or not.

These images try to have as few things as possible to cover most use cases. However, I know some people ask every now and then about installing certificates. If you want, I'd be happy to receive a contribution to the README showing how to do it. Would you be OK with that?

[algoritmus]

Sure, no problem.

…

On Thu, 12 May 2022 at 16:36 Diego Molina ***@***.***> wrote: @algoritmus <https://github.com/algoritmus> thanks for being open about it. I am not sure if it is a common use case or not. These images try to have as few things as possible to cover most use cases. However, I know some people ask every now and then about installing certificates. If you want, I'd be happy to receive a contribution to the README showing how to do it. Would you be OK with that? — Reply to this email directly, view it on GitHub <#1567 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADK3FF3EZBWJDIXQY4AVETDVJUJQTANCNFSM5VOJ7VPA> . You are receiving this because you were mentioned.Message ID: ***@***.***>