Skip to content

Bumping to 4.7.2 #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2022
Merged

Bumping to 4.7.2 #1744

merged 2 commits into from
Dec 17, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 15, 2022

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Bumping to Selenium Grid 4.7.2

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@diemol
Copy link
Member

diemol commented Dec 15, 2022

Seems the build is failing because of the coursier download and execution https://github.com/SeleniumHQ/docker-selenium/actions/runs/3702914588/jobs/6274019397#step:9:1071

@krmahadevan @xcalizorz do you have time to have a look?

@krmahadevan
Copy link
Contributor

Seems the build is failing because of the coursier download and execution https://github.com/SeleniumHQ/docker-selenium/actions/runs/3702914588/jobs/6274019397#step:9:1071

@krmahadevan @xcalizorz do you have time to have a look?

@diemol - I am seeing this error

/tmp/cs: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /tmp/cs)

I went back to the coursiers repo and noticed that there was a change done coursier/launchers@60da306

Not sure if that would be the cause. I dont have a UNIX machine to try this out and confirm this theory

@ghost
Copy link
Author

ghost commented Dec 15, 2022

Seems the build is failing because of the coursier download and execution https://github.com/SeleniumHQ/docker-selenium/actions/runs/3702914588/jobs/6274019397#step:9:1071
@krmahadevan @xcalizorz do you have time to have a look?

@diemol - I am seeing this error

/tmp/cs: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /tmp/cs)

I went back to the coursiers repo and noticed that there was a change done coursier/launchers@60da306

Not sure if that would be the cause. I dont have a UNIX machine to try this out and confirm this theory

It looks like coursier was built using glibc 2.32 and the image has an older version:

root@xcalizorz:/# ldd --version
ldd (Ubuntu GLIBC 2.31-0ubuntu9.9) 2.31
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Written by Roland McGrath and Ulrich Drepper.

It seems that Ubuntu focal repositories do not have glibc 2.32, yet:

root@xcalizorz:/# apt-get install libc6
Reading package lists... Done
Building dependency tree       
Reading state information... Done
libc6 is already the newest version (2.31-0ubuntu9.9).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.

I would not recommend updating glibc manually (building, etc. needed) since it is a very central library and we should use the one shipped with ubuntu.

ubuntu:focal provides glibc 2.31; so we need to update to a newer ubuntu version.

The latest LTS for ubuntu would be jammy with glibc 2.35. I have some issues building the image, when all tests pass locally, we can try updating the version of ubuntu. What do you think?

The native installer needs glibc 2.32 which is not provided by any Ubuntu LTS version per default.
@ghost
Copy link
Author

ghost commented Dec 15, 2022

Using jammy was unsuccessful (same error, because glibc 2.35 != 2.32 😢)

Currently, the only quick solution would be to use the JAR based coursier launcher instead of using the native one (see my latest commit).

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @xcalizorz!

@diemol diemol merged commit c9e8066 into SeleniumHQ:trunk Dec 17, 2022
@diemol diemol mentioned this pull request Dec 17, 2022
8 tasks
prashanth-volvocars pushed a commit to prashanth-volvocars/docker-selenium that referenced this pull request Jun 29, 2023
* Bumping to 4.7.2

* Use JAR based coursier launcher

The native installer needs glibc 2.32 which is not provided by any Ubuntu LTS version per default.

Co-authored-by: Xcalizorz <[email protected]>

[deploy]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants