Skip to content

Update Dockerfile #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Feb 21, 2023
Merged

Update Dockerfile #1773

merged 21 commits into from
Feb 21, 2023

Conversation

StevenBOULLE
Copy link
Contributor

Change rights to 775

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Jan 18, 2023

CLA assistant check
All committers have signed the CLA.

@StevenBOULLE StevenBOULLE changed the base branch from update-chmod-permissions to trunk January 18, 2023 09:46
@StevenBOULLE StevenBOULLE changed the base branch from trunk to update-chmod-permissions January 18, 2023 09:46
@diemol diemol force-pushed the update-chmod-permissions branch from 593a7b7 to 8e0c6da Compare January 18, 2023 09:48
@diemol diemol changed the base branch from update-chmod-permissions to trunk January 18, 2023 09:55
@diemol diemol mentioned this pull request Jan 18, 2023
8 tasks
@diemol
Copy link
Member

diemol commented Jan 18, 2023

Thanks for the PR, @StevenBOULLE! Sadly it still fails.

Change group of directories "/opt/selenium ${HOME} /opt/selenium/assets /var/run/supervisor /var/log/supervisor" to group seluser
Usage of ACL to stay with root's rights for user and group but add some rights to user seluser with ACL
Copy link
Contributor Author

@StevenBOULLE StevenBOULLE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explanation given

@StevenBOULLE
Copy link
Contributor Author

I have 2 merge requests, I close one

@StevenBOULLE
Copy link
Contributor Author

missunderstanding

@StevenBOULLE StevenBOULLE reopened this Jan 23, 2023
@StevenBOULLE StevenBOULLE requested a review from diemol February 21, 2023 13:16
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @StevenBOULLE!

@diemol diemol merged commit 2670ff3 into SeleniumHQ:trunk Feb 21, 2023
@diemol diemol mentioned this pull request Feb 21, 2023
8 tasks
prashanth-volvocars pushed a commit to prashanth-volvocars/docker-selenium that referenced this pull request Jun 29, 2023
* Tuning chmod permissions

* Kick CI

* More tuning

* Tuning a bit more

* Update Dockerfile

Change rights to 775

* Update Dockerfile

Change rights

* Tuning chmod permissions

* More tuning

* Tuning a bit more

* Change group for some directories

Change group of directories "/opt/selenium ${HOME} /opt/selenium/assets /var/run/supervisor /var/log/supervisor" to group seluser

* Usage of ACL

Usage of ACL to stay with root's rights for user and group but add some rights to user seluser with ACL

* Install ACL package

* typo in command setfacl

* change stefacl location on script

* Change setfacl location once again

* add acl to /opt

* Update Dockerfile

Adding sudo to avoid "permission denied" messages

---------

Co-authored-by: Diego Molina <[email protected]>
Co-authored-by: Diego Molina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants