-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Update Dockerfile #1773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update Dockerfile #1773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change rights to 775
Change rights
593a7b7
to
8e0c6da
Compare
Thanks for the PR, @StevenBOULLE! Sadly it still fails. |
Change group of directories "/opt/selenium ${HOME} /opt/selenium/assets /var/run/supervisor /var/log/supervisor" to group seluser
diemol
reviewed
Jan 18, 2023
Usage of ACL to stay with root's rights for user and group but add some rights to user seluser with ACL
diemol
requested changes
Jan 18, 2023
StevenBOULLE
commented
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explanation given
I have 2 merge requests, I close one |
missunderstanding |
Adding sudo to avoid "permission denied" messages
diemol
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @StevenBOULLE!
prashanth-volvocars
pushed a commit
to prashanth-volvocars/docker-selenium
that referenced
this pull request
Jun 29, 2023
* Tuning chmod permissions * Kick CI * More tuning * Tuning a bit more * Update Dockerfile Change rights to 775 * Update Dockerfile Change rights * Tuning chmod permissions * More tuning * Tuning a bit more * Change group for some directories Change group of directories "/opt/selenium ${HOME} /opt/selenium/assets /var/run/supervisor /var/log/supervisor" to group seluser * Usage of ACL Usage of ACL to stay with root's rights for user and group but add some rights to user seluser with ACL * Install ACL package * typo in command setfacl * change stefacl location on script * Change setfacl location once again * add acl to /opt * Update Dockerfile Adding sudo to avoid "permission denied" messages --------- Co-authored-by: Diego Molina <[email protected]> Co-authored-by: Diego Molina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change rights to 775
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist