Make ingress compatible with format prior to 1.19-0 k8s version #1798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Can you please sign the CLA and also bump de version of the Charts + Changelog so it can be released right away? |
|
I signed the SLA and modified the Changelog |
|
You also would need to update the |
|
Thank you for the quick answers |
prashanth-volvocars
pushed a commit
to prashanth-volvocars/docker-selenium
that referenced
this pull request
Jun 29, 2023
…niumHQ#1798) * Make ingress compatible with format prior to 1.19-0 k8s version * Modify CHANGELOG.md * Modify Chart version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR objective is to support old ingress API version.
In our case we use a 3.11 OpenShift (kubernetes 1.11) and we had this error message:
Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: error validating "": error validating data: [ValidationError(Ingress.spec.rules[0].http.paths[0].backend): unknown field "service" in io.k8s.api.extensions.v1beta1.IngressBackend, ValidationError(Ingress.spec.rules[0].http.paths[0].backend): missing required field "serviceName" in io.k8s.api.extensions.v1beta1.IngressBackend, ValidationError(Ingress.spec.rules[0].http.paths[0].backend): missing required field "servicePort" in io.k8s.api.extensions.v1beta1.IngressBackend, ValidationError(Ingress.spec.rules[0].http.paths[0]): unknown field "pathType" in io.k8s.api.extensions.v1beta1.HTTPIngressPath]So I added a if to check if the kubernetes is in version prior to 1.19-0 to use the old ingress API