-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Docker: Enable SE_NODE_ENABLE_MANAGED_DOWNLOADS
by default
#2869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Viet Nguyen Duc <[email protected]>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
CI Feedback 🧐(Feedback updated until commit 1d089ae)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Most users might be aware of RemoteWebDriver manage downloads file https://www.selenium.dev/documentation/webdriver/drivers/remote_webdriver/#downloads
To use this feature, need to enable it in client binding AND also enable it in Node config for slot matching, otherwise the Session request will wait in the queue until it times out.
However, the config in Node is missed by most users until they see the error.
In the container env var,
SE_NODE_ENABLE_MANAGED_DOWNLOADS
is used to pass the CLI config when starting the Node. To help users get a better experience, this will be set astrue
by default.By enabling this by default, there is no impact for use cases where the user is not enabling the remote downloads manager.
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
• Enable
SE_NODE_ENABLE_MANAGED_DOWNLOADS
by default in Docker containers• Update environment variable documentation and configuration files
• Improve user experience for remote download management feature
Changes walkthrough 📝
ENV_VARIABLES.md
Update environment variable documentation
ENV_VARIABLES.md
• Updated
SE_NODE_ENABLE_MANAGED_DOWNLOADS
default value from empty totrue
Dockerfile
Enable managed downloads in base image
NodeBase/Dockerfile
• Added
SE_NODE_ENABLE_MANAGED_DOWNLOADS="true"
environment variableto Docker image
value.yaml
Update configuration generation script
scripts/generate_list_env_vars/value.yaml
• Changed
SE_NODE_ENABLE_MANAGED_DOWNLOADS
default from empty stringto
'true'