Skip to content

Conversation

@Plotist
Copy link

@Plotist Plotist commented Apr 30, 2018

By request from #160

@Plotist
Copy link
Author

Plotist commented May 14, 2018

@corevo is there something that needs to be done for it to be merged ?

@corevo
Copy link
Member

corevo commented May 14, 2018

No, this is on me, I want to manually check this, also applies for #171
I can just think of a few edge cases that may arise and I want to make sure that the automatic suite covers them, since the side format not as human readable as code, I'll have to check this out in the IDE.

@corevo
Copy link
Member

corevo commented Jun 4, 2018

Since behind the scenes when we export verify and assert are the same, the test is needlessly slower.
Instead change the selected label, and check that it works.

@corevo corevo merged commit 48e2b3c into SeleniumHQ:master Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants