Handle EPIPE errors along with the current ECONNRESET #3443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an open issue with Node.js throwing EPIPE errors when you pipe to a closed stream. This was causing me unpredictable errors while loading pages. The errors are pretty similar to ECONNRESET in the sense that you could simply try again and shouldn't throw every time it happens. More info here: nodejs/node#947
|
I've been running into this issue with Protractor: angular/protractor#4294 After manually adding that fix, I have not seen the EPIPE errors in our test suites. Granted, I've been running our test suites with the fix only a couple of times so far. |
p0deje
added
C-nodejs
|
Sorry we let this PR sit for a year without review :( Retries for EPIPE errors was added in c41f9ef |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an open issue with Node.js throwing EPIPE errors when you pipe to a closed stream. This was causing me unpredictable errors while loading pages.
The errors are pretty similar to ECONNRESET in the sense that you could simply try again and shouldn't throw every time it happens.
More info here: nodejs/node#947
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement