Added more details on moveByOffset to make it clear which directions the mouse moves #1092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…X and Y move the mouse. Issue SeleniumHQ#1087
diemol
requested changes
Jul 28, 2022
selenium-ci
added a commit
that referenced
this pull request
Jul 28, 2022
…the mouse moves (#1092) * Added more details on moveByOffset to make it clear which directions X and Y move the mouse. Issue #1087 * Added the text to the other language files. Co-authored-by: Diego Molina <[email protected]> [deploy site] 93b32c8
✅ Deploy Preview for jovial-austin-42fe02 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1087
I felt the documentation for moveByOffset wasn't clear in terms of how the mouse moves based on X and Y inputs. So I propose this change to make it clear how a positive X and a positive Y moves the mouse pointer.
Description
This is a simple addition to the moveByOffset documentation.
Motivation and Context
I myself experienced some confusion on this. I incorrectly assumed a positive Y would move the mouse up. But after experimenting I realized a positive Y moves the mouse down. So I documented that in this PR. I have also seen other QA engineers struggle with the mouse portion of the Actions API. I hope these changes will make it more clear.
Types of changes
Checklist