Skip to content

Fix first Java script example and doc #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

bonigarcia
Copy link
Member

@bonigarcia bonigarcia commented Aug 8, 2022

Description

This PR fix the first Java script example and page, currently broken.

Motivation and Context

I broke this page on #1081, sorry.

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@netlify
Copy link

netlify bot commented Aug 8, 2022

Deploy Preview for jovial-austin-42fe02 ready!

Name Link
🔨 Latest commit 5a320c4
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/62f0f186fc9f64000880a0b2
😎 Deploy Preview https://deploy-preview-1108--jovial-austin-42fe02.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bonigarcia!

@diemol diemol merged commit 60e6173 into SeleniumHQ:trunk Aug 8, 2022
selenium-ci added a commit that referenced this pull request Aug 8, 2022
@bonigarcia bonigarcia deleted the fix_java_basic_example branch August 8, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants