Skip to content

Update getting_started.zh-cn.md #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 16, 2023
Merged

Conversation

iamxiaojianzheng
Copy link
Contributor

@iamxiaojianzheng iamxiaojianzheng commented Mar 13, 2023

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2023

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Mar 13, 2023

Deploy Preview for jovial-austin-42fe02 ready!

Name Link
🔨 Latest commit fef297b
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/6412dfe0c9abb200084500e4
😎 Deploy Preview https://deploy-preview-1335--jovial-austin-42fe02.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@alaahong alaahong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts. Almost good, can you take a look into the highlight parts?

Copy link
Member

@alaahong alaahong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see such contributions, just need follow the Selenium rule and no need to refresh existing file if no content changed or missed.

wrap some lines
@harsha509
Copy link
Member

Thank you for the review @alaahong !

@harsha509 harsha509 merged commit 0b8f171 into SeleniumHQ:trunk Mar 16, 2023
selenium-ci added a commit that referenced this pull request Mar 16, 2023
* Update getting_started.zh-cn.md

* Update getting_started.zh-cn.md

Modify some language expressions

* Update getting_started.zh-cn.md

Modify some language expressions

* Modify some language expressions

* Update applicability.zh-cn.md

* Update components.zh-cn.md

* Update errors.zh-cn.md

make sentences more fluent

* Update components.zh-cn.md

add some notes

* Update windows.zh-cn.md

format java code

* Update errors.zh-cn.md

wrap some lines

---------

Co-authored-by: ian zhang <[email protected]> 0b8f171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants