Skip to content

Update how Selenium Manager is described #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2023
Merged

Update how Selenium Manager is described #1390

merged 3 commits into from
May 26, 2023

Conversation

titusfortner
Copy link
Member

@titusfortner titusfortner commented May 19, 2023

Description

Minimizing the focus on Selenium Manager in Webdriver docs

Motivation and Context

People are getting confused

This is English only just to get feedback

@netlify
Copy link

netlify bot commented May 19, 2023

Deploy Preview for selenium-dev ready!

Name Link
🔨 Latest commit cbd5769
🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/646fa441a784310008781b1c
😎 Deploy Preview https://deploy-preview-1390--selenium-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@titusfortner titusfortner marked this pull request as ready for review May 19, 2023 20:55
@titusfortner titusfortner marked this pull request as draft May 19, 2023 20:56
@titusfortner titusfortner marked this pull request as ready for review May 19, 2023 21:10
Copy link
Contributor

@luisfcorreia luisfcorreia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feedback on changes

@titusfortner
Copy link
Member Author

@bonigarcia I'm sure there's more we can add to the Selenium Manager page, but I made a first draft of things.

@titusfortner
Copy link
Member Author

Note to self: verify the redirects.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great rework, thank you!

@titusfortner titusfortner force-pushed the sm branch 3 times, most recently from 883e33f to ce86669 Compare May 22, 2023 21:16
@titusfortner titusfortner changed the title WIP - driver install redo (English only) Update how Selenium Manager is described May 22, 2023
@harsha509 harsha509 merged commit d0124a4 into trunk May 26, 2023
@harsha509 harsha509 deleted the sm branch May 26, 2023 00:11
selenium-ci added a commit that referenced this pull request May 26, 2023
* Update how Selenium Manager is described

[deploy site]

* fix links

---------

Co-authored-by: Sri Harsha <[email protected]> d0124a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants