You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change banner to reflect registrations now that CFP has closed
Thanks for contributing to the Selenium site and documentation! A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Updated banner now that CFP is closed and registrations are open for Selenium Conf
Motivation and Context
CFP is no longer relevant for the conference
Types of changes
[ x ] Change to the site (I have double-checked the Netlify deployment, and my changes look good)
Code example added (and I also added the example to all translated languages)
Improved translation
Added new translation (and I also added a notice to each document missing translation)
1, because the PR involves a simple text change in an HTML file, which is straightforward and does not require deep code review or understanding of complex logic.
Add rel="noopener noreferrer" to the anchor tag to enhance security
It is recommended to use rel="noopener noreferrer" in the anchor tag to improve security. This prevents the new page from being able to access the window object of the page that opened it, which can protect against certain types of attacks such as phishing.
Why: Adding rel="noopener noreferrer" enhances security by preventing the newly opened page from accessing the window object of the opening page, which is a significant security improvement.
8
Accessibility
Add aria-label to the anchor tag to improve accessibility for screen readers
Consider using aria-label on the anchor tag to improve accessibility. This provides a text alternative that describes the purpose of the link, which is beneficial for screen reader users.
Why: Adding aria-label improves accessibility for screen reader users by providing a clear description of the link's purpose, which is a good practice for web accessibility.
7
Enhancement
Improve hyperlink visibility with contrasting color and underline
To enhance the visual accessibility, consider adding a contrasting color or underline to the hyperlink to make it stand out more prominently against the background.
Why: Improving hyperlink visibility with contrasting color and underline can significantly enhance visual accessibility, making it easier for users to identify clickable links.
6
Maintainability
Standardize the use of double quotes for HTML attribute values
Ensure consistent HTML attribute quoting by using double quotes around all attribute values. This improves the readability and maintainability of the code.
Why: Standardizing the use of double quotes for HTML attributes enhances code readability and maintainability, although it's a relatively minor improvement.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Change banner to reflect registrations now that CFP has closed
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Updated banner now that CFP is closed and registrations are open for Selenium Conf
Motivation and Context
CFP is no longer relevant for the conference
Types of changes
Checklist
PR Type
Enhancement
Description
Changes walkthrough 📝
announcement-banner.html
Update Announcement Banner for Selenium Conf 2024
website_and_docs/layouts/partials/announcement-banner.html
registration opening for Selenium Conf 2024.
the call for proposals page.