-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Added Chrome devtools features #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sync with master
Sync from the master
Updating the fork with master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nainappa ,
Thanks for the PR. i've couple of things
- I think this feature is not ready yet(not fully supported/ have few bugs)
- I have tried the code samples and am unable to execute code(running into issues with selenium alpha 5)
- I think CDP is not a part of WebDriver specification(am not sure on this). If not, we need to move it out from WebDriver Section
Regards,
Harsha
Hi @harsha509 Thanks for reviewing the changes. Below are in-line response.
|
Hi @harsha509 I removed network emulation feature. Please take a look when you have time. |
Hi @harsha509 Do you have any updates on this? If it doesnt make sense, I can close the PR. |
Hi @nainappa The PR is Awesome. Please give us some time as the the team members/core committers also have few suggestions as this is the important feature landing in Selenium4. Regards, |
Hi @nainappa , I would like to move this document to If you are ok with it, can you please make changes. I will merge it. Regards, |
Hi @harsha509 Sure. I will raise PR with the changes. Thanks for the review. |
Hi @harsha509, I changed the location to Support Packages now. Please take a look when you have time. |
Sure. The build is already in progress :) I'll merge it when the build is good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @nainappa !
* Added Chrome Devtools features * Removed emulate Network Conditions method * Removed emulate Network Conditions method * Changed the location to Support Packages Co-authored-by: Diego Molina <[email protected]> Co-authored-by: Sri Harsha <[email protected]> 9f9cf75
Description
Added chrome devtools features that are part of Selenium4-alpha versions.
Motivation and Context
The example code snippets would help the users to understand more about the features.
Types of changes
Checklist
After: