Sample of Get Element CSS Value #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

harsha509 merged 2 commits into SeleniumHQ:dev from Peyton88:dev

Sep 27, 2020

Contributor

Peyton88 commented Sep 22, 2020 •

edited

Loading

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

Change to the site (I am attaching a screenshot showing the before and after)
Code example added (and I also added the example to all translated languages)
Improved translation
Added new translation (and I also added a notice to each document missing translation)

Checklist

I have read the contributing document.
I have used hugo to render the site/docs locally and I am sure it works.

CLAassistant commented Sep 22, 2020 •

edited

Loading

All committers have signed the CLA.

Peyton88 force-pushed the dev branch from 4e4841d to 3f5e098 Compare

September 23, 2020 05:01

harsha509 requested changes

View reviewed changes

Member

harsha509 left a comment •

edited

Loading

Thanks for the PR!

get Element css value actually returns a value of computed css style property of an element. we have WebDriver method like getCssValue in JS. The code sample you've provided is for getAttribute

i've updated doc with a code sample for JS. https://www.selenium.dev/documentation/fr/webdriver/web_element/#get-element-css-value

can you please update the code samples accordingly.

Thank you !

Peyton88 force-pushed the dev branch from 3f5e098 to d32aed3 Compare

September 24, 2020 16:56

Contributor Author

Peyton88 commented Sep 24, 2020

Hi @Peyton88 ,

Thanks for the PR!

get Element css value actually returns a value of computed css style property of an element. we have WebDriver method like getCssValue in JS. The code sample you've provided is for getAttribute

i've updated doc with a code sample for JS. https://www.selenium.dev/documentation/fr/webdriver/web_element/#get-element-css-value

can you please update the code samples accordingly.

Thank you !

Thanks. I got a misunderstanding.
I've updated my commit.

harsha509 requested changes

View reviewed changes

Member

harsha509 left a comment •

edited

Loading

Thank you for making the changes. and apologies for reverting it, there are couple of things required to get this pr merged !

Can you please fill/complete the above checklist.
Semicolons are not required in few language bindings like kotlin, ruby, python can you please look into the suggested changes
Can you please make the same changes in other translated pages too like (es,fr,zh-cn).

Thank you!

docs_source_files/content/webdriver/web_element.en.md Outdated

+              driver.get 'https://www.example.com'
+              # Retrieves the computed style property 'color' of linktext
+              cssValue = driver.find_element(:link_text, 'More information...').css_value('color');

Member

harsha509 Sep 24, 2020

Suggested change

      
            cssValue = driver.find_element(:link_text, 'More information...').css_value('color');
          
            cssValue = driver.find_element(:link_text, 'More information...').css_value('color')

docs_source_files/content/webdriver/web_element.en.md Outdated

-              // Please provide a pr for the code sample
+              // Navigate to Url
+              driver.get('https://www.example.com');

Member

harsha509 Sep 24, 2020

Suggested change

      
            driver.get('https://www.example.com');
          
            driver.get('https://www.example.com')

docs_source_files/content/webdriver/web_element.en.md Outdated

+              driver.get('https://www.example.com');
+              # Retrieves the computed style property 'color' of linktext
+              cssValue = driver.findElement(By.LINK_TEXT, "More information...").value_of_css_property('color');

Member

harsha509 Sep 24, 2020

Suggested change

      
            cssValue = driver.findElement(By.LINK_TEXT, "More information...").value_of_css_property('color');
          
            cssValue = driver.findElement(By.LINK_TEXT, "More information...").value_of_css_property('color')

docs_source_files/content/webdriver/web_element.en.md Outdated

-              // Please provide a pr for the code sample
+              # Navigate to Url
+              driver.get('https://www.example.com');

Member

harsha509 Sep 24, 2020

Suggested change

      
            driver.get('https://www.example.com');
          
            driver.get('https://www.example.com')

docs_source_files/content/webdriver/web_element.en.md Outdated

+              driver.get('https://www.example.com');
+              // Retrieves the computed style property 'color' of linktext
+              val cssValue = driver.findElement(By.linkText("More information...")).getCssValue('color');

Member

harsha509 Sep 24, 2020

Suggested change

      
            val cssValue = driver.findElement(By.linkText("More information...")).getCssValue('color');
          
            val cssValue = driver.findElement(By.linkText("More information...")).getCssValue('color')


          Sample of Get Element CSS Value

b31bc97

Peyton88 force-pushed the dev branch from d32aed3 to b31bc97 Compare

September 26, 2020 16:42

Contributor Author

Peyton88 commented Sep 26, 2020 •

edited

Loading

hi @Peyton88 ,

Thank you for making the changes. and apologies for reverting it, there are couple of things required to get this pr merged !

Can you please fill/complete the above checklist.

Semicolons are not required in few language bindings like kotlin, ruby, python can you please look into the suggested changes

Can you please make the same changes in other translated pages too like (es,fr,zh-cn).

Thank you!

Hi @harsha509 ,

Thanks for your kindly reminding.
Please see my updates.

harsha509 approved these changes

View reviewed changes

Member

harsha509 left a comment

Thank you @Peyton88 !


          Merge branch 'dev' into dev

e843b50

Member

harsha509 commented Sep 27, 2020

deploy-preview looks good !

harsha509 merged commit bae2e36 into SeleniumHQ:dev

selenium-ci added a commit that referenced this pull request


          Sample of Get Element CSS Value (#527)[deploy site]

f3454b8

Co-authored-by: Sri Harsha <[email protected]> bae2e36

Member

harsha509 commented Sep 27, 2020

Congratulations on your first contribution @Peyton88 🎉 🎉 🎉 🎉 🎉

Contributor Author

Peyton88 commented Sep 27, 2020

Congratulations on your first contribution @Peyton88 🎉 🎉 🎉 🎉 🎉

Thanks you~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet