closes #533 #535
Merged
closes #533 #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
described attachment download option via HtmlUnit
|
|
harsha509
previously requested changes
Oct 14, 2020
There was a problem hiding this comment.
hi @skyhirider !
Thanks for the PR !
Can you please make same changes in other translated pages too (like es, zh-cn etc)
|
@harsha509 You mean translate it? Best I could do is run it through google translate, did you mean that? My native tongue is Slovak and have a limited grasp of German, and that is pretty much it. |
|
@skyhirider I replied here |
|
Hi @skyhirider , Did you get a chance to look into the above comments/suggestions ? |
|
Hi @JS31096 I will have a look, still want to make the change just need to find time to do it. |
|
@JS31096 added English text to other language versions with the disclaimer. Also ticked the checkbox for the CLA |
diemol
reviewed
Nov 8, 2020
diemol
reviewed
Nov 8, 2020
diemol
reviewed
Nov 8, 2020
diemol
reviewed
Nov 8, 2020
diemol
reviewed
Nov 8, 2020
diemol
reviewed
Nov 8, 2020
docs_source_files/content/worst_practices/file_downloads.zh-cn.md
Outdated
Show resolved
Hide resolved
diemol
approved these changes
Nov 8, 2020
selenium-ci
added a commit
that referenced
this pull request
Nov 8, 2020
* closes #533 described attachment download option via HtmlUnit * added untranslated text to all other languages * Update docs_source_files/content/worst_practices/file_downloads.es.md * Update docs_source_files/content/worst_practices/file_downloads.fr.md * Update docs_source_files/content/worst_practices/file_downloads.ja.md * Update docs_source_files/content/worst_practices/file_downloads.ko.md * Update docs_source_files/content/worst_practices/file_downloads.nl.md * Update docs_source_files/content/worst_practices/file_downloads.zh-cn.md Co-authored-by: Diego Molina <[email protected]> caead29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
described attachment download option via HtmlUnit
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
closes #533
Motivation and Context
as mentioned in issue, a lot of people are looking to download files from ajax sites and selenium + htmlunit is one of the few options available if you asynchronously receive a download response
Types of changes
Checklist