Skip to content

[chrome_devtools] add Basic Auth example in Java #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 13, 2021
Merged

[chrome_devtools] add Basic Auth example in Java #658

merged 5 commits into from
Apr 13, 2021

Conversation

dbudim
Copy link
Contributor

@dbudim dbudim commented Apr 8, 2021

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Added Java example of using Basic Auth via chrome dev tools

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@CLAassistant
Copy link

CLAassistant commented Apr 8, 2021

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Apr 8, 2021

Deploy preview for jovial-austin-42fe02 ready!

Built with commit f293af4

https://deploy-preview-658--jovial-austin-42fe02.netlify.app

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dbudim ,

Thank for the PR.
Can you look into the comments.

Also, am unable to execute the code sample after doing modifications as below

Predicate<URI> uriPredicate = uri -> uri.getHost().contains("https://the-internet.herokuapp.com"); ((HasAuthentication) driver).register(uriPredicate, UsernameAndPassword.of("admin", "admin")); driver.get("https://the-internet.herokuapp.com/basic_auth");

:wave @diemol , Can you please review the code sample and suggest the correct one.

Thank you!

@dbudim dbudim requested a review from harsha509 April 12, 2021 07:10
Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dbudim !

@harsha509 harsha509 merged commit d5b4294 into SeleniumHQ:dev Apr 13, 2021
@harsha509
Copy link
Member

Congratulations on your first contribution to Selenium docs @dbudim 🎉 🎉

selenium-ci added a commit that referenced this pull request Apr 13, 2021
* [chrome_devtools] add Basic Auth example in Java

* [chrome_devtools] add driver type that supports basic auth

* [chrome_devtools] add HasAuthentication

Co-authored-by: Sri Harsha <[email protected]> d5b4294
@dbudim
Copy link
Contributor Author

dbudim commented Apr 13, 2021

Congratulations on your first contribution to Selenium docs @dbudim 🎉 🎉

Thank you 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants