-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add dismissible banner shortcode #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add CVE-2021-45105 vulnerability banner
✔️ Deploy Preview for jovial-austin-42fe02 ready! 🔨 Explore the source changes: 5b917c6 🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-austin-42fe02/deploys/61c241b479251400075c89f7 😎 Browse the preview: https://deploy-preview-898--jovial-austin-42fe02.netlify.app |
https://deploy-preview-898--jovial-austin-42fe02.netlify.app/ - Looks good to me. |
@manoj9788 - would you mind reviewing? 🙏 |
I'm not an authorized reviewer, but I approve your changes. |
Now that I think about it... was it CVE-2021-44228 ? |
Perhaps there were multiple Log4j vulnerabilities in the wild. If there are more than one, perhaps we don't need to mention a specific one at all? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @ddavison! I started working on that generic banner long time ago and forgot about it. Thanks for fixing it!
BTW I would just say Log4j without mentioning the specific vulnerability. But up to you.
Also, when merging, add [deploy site] to the commit message so the change gets actually deployed.
LGTM. Thanks @ddavison good to see you back! :) |
Add log4j vulnerability banner [deploy site] 4ebe9ab
Description
Motivation and Context
Noting the Selenium software is not affected by CVE-2021-45105 .
rel: #897
Screenshot
Types of changes
Checklist