Skip to content

Missing 'page' in JavaScript example for network interceptor #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 8, 2022

Conversation

TheTestLynx
Copy link
Contributor

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Missing 'page' in JavaScript example for network interceptor

Motivation and Context

Avoid confusion when no other cdp connection were created before

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works. !!!!!! Not tested / Got not local space atm

'page' parameter missing
'page' parameter missing
'page' parameter missing
'page' parameter missing
@CLAassistant
Copy link

CLAassistant commented Feb 6, 2022

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Feb 6, 2022

✔️ Deploy Preview for jovial-austin-42fe02 ready!

🔨 Explore the source changes: 4233b90

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-austin-42fe02/deploys/620200a19a8cb30007419ef0

😎 Browse the preview: https://deploy-preview-949--jovial-austin-42fe02.netlify.app

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @TheTestLynx !

@harsha509 harsha509 merged commit 1eae215 into SeleniumHQ:dev Feb 8, 2022
selenium-ci added a commit that referenced this pull request Feb 8, 2022
…eploy site]

* Update bidi_api.en.md

'page' parameter missing

* Update bidi_api.ja.md

'page' parameter missing

* Update bidi_api.zh-cn.md

'page' parameter missing

* Update bidi_api.pt-br.md

'page' parameter missing

Co-authored-by: Sri Harsha <[email protected]> 1eae215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants