This repository was archived by the owner on Dec 24, 2022. It is now read-only.
Update DateTimeExtensions.cs DateTimeOffset #537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include DateTimeOffset arg to extension method ToUnixTimeMs. Made the assumption to use 'UtcDateTime' to use original DateTime implementation. Possibly a better way exists. Note 1: Due to `private static ToDateTimeSinceUnixEpoch` and `internal DateTimeSerializer.LocalTimeZone` had to re-implement to get it to work. Note 2: `ToUnixTimeMsAlt` should probably also have a DateTimeOffset implementation, but I did not implement.
|
Or could have done something simpler and done the following. Not sure how mythz would want it. Change it to however you want. |
|
Yep either works, thx for the PR 👍 |
|
FYI decided to collapse the unnecessary method call, so it's now just: public static long ToUnixTimeMs(this DateTimeOffset dateTimeOffset) =>
(long)ToDateTimeSinceUnixEpoch(dateTimeOffset.UtcDateTime).TotalMilliseconds; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include DateTimeOffset arg to extension method ToUnixTimeMs. Made the assumption to use 'UtcDateTime' to use original DateTime implementation. Possibly a better way exists.
Note 1: Due to
private static ToDateTimeSinceUnixEpochandinternal DateTimeSerializer.LocalTimeZonehad to re-implement to get it to work.Note 2:
ToUnixTimeMsAltshould probably also have a DateTimeOffset implementation, but I did not implement.