check if middleware does exist #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jondubois
requested changes
Mar 10, 2018
scserver.js
Outdated
| @@ -639,6 +639,9 @@ SCServer.prototype.generateId = function () { | |||
| }; | |||
|
|
|||
| SCServer.prototype.addMiddleware = function (type, middleware) { | |||
| if (!this._middleware[type]) { | |||
| throw new InvalidArgumentsError(`Middleware type "${type}" is not supported. \nRead more: https://socketcluster.io/#!/docs/middleware-and-authorization`) | |||
There was a problem hiding this comment.
Avoid \n new lines and references to websites inside error messages (keep them simple), but feel free to add references to the website inside comments above the error message if you like.
There was a problem hiding this comment.
Also missing semicolon at the end of the line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give a proper error message instead of ambigous