Skip to content

Chapter 05 loops #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Oct 9, 2018
Merged

Chapter 05 loops #10

merged 20 commits into from
Oct 9, 2018

Conversation

mdamyanova
Copy link
Collaborator

I think I'm done with my chapter. Let me know if there is something to fix.

Copy link
Collaborator

@miglen miglen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Линковете към задачите водят към стара група, а трябва да бъдат към: https://judge.softuni.bg/Contests/Practice/Index/1053
Картинките на мен ми изглеждат окей.
Бих посъветвал да смачкаш комитите (squash commits). 👍


#### Тестване в Judge системата

Тествайте решението си тук: [https://judge.softuni.bg/Contests/Practice/Index/510#0](https://judge.softuni.bg/Contests/Practice/Index/510#0).
Тествайте решението си тук: [https://judge.softuni.bg/Contests/Practice/Index/154#0](https://judge.softuni.bg/Contests/Practice/Index/154#0).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


#### Тестване в Judge системата

Тествайте решението си тук: [https://judge.softuni.bg/Contests/Practice/Index/510#1](https://judge.softuni.bg/Contests/Practice/Index/510#1).
Тествайте решението си тук: [https://judge.softuni.bg/Contests/Practice/Index/154#1](https://judge.softuni.bg/Contests/Practice/Index/154#1).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


#### Тестване в Judge системата

Тествайте решението си тук: [https://judge.softuni.bg/Contests/Practice/Index/510#3](https://judge.softuni.bg/Contests/Practice/Index/510#3).
Тествайте решението си тук: [https://judge.softuni.bg/Contests/Practice/Index/154#3](https://judge.softuni.bg/Contests/Practice/Index/154#3).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


#### Тестване в Judge системата

Тествайте решението си тук: [https://judge.softuni.bg/Contests/Practice/Index/510#7](https://judge.softuni.bg/Contests/Practice/Index/510#7).
Тествайте решението си тук: [https://judge.softuni.bg/Contests/Practice/Index/154#7](https://judge.softuni.bg/Contests/Practice/Index/154#7).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


#### Тестване в Judge системата

Тествайте решението си тук: [https://judge.softuni.bg/Contests/Practice/Index/510#6](https://judge.softuni.bg/Contests/Practice/Index/510#6).
Тествайте решението си тук: [https://judge.softuni.bg/Contests/Practice/Index/154#6](https://judge.softuni.bg/Contests/Practice/Index/154#6).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


#### Тестване в Judge системата

Тествайте решението си тук: [https://judge.softuni.bg/Contests/Practice/Index/510#5](https://judge.softuni.bg/Contests/Practice/Index/510#5).
Тествайте решението си тук: [https://judge.softuni.bg/Contests/Practice/Index/154#5](https://judge.softuni.bg/Contests/Practice/Index/154#5).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -279,7 +268,7 @@

#### Тестване в Judge системата

Тествайте решението си тук: [https://judge.softuni.bg/Contests/Practice/Index/510#9](https://judge.softuni.bg/Contests/Practice/Index/510#9).
Тествайте решението си тук: [https://judge.softuni.bg/Contests/Practice/Index/154#9](https://judge.softuni.bg/Contests/Practice/Index/154#9).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -303,7 +292,7 @@

#### Тестване в Judge системата

Тествайте решението си тук: [https://judge.softuni.bg/Contests/Practice/Index/510#10](https://judge.softuni.bg/Contests/Practice/Index/510#10).
Тествайте решението си тук: [https://judge.softuni.bg/Contests/Practice/Index/154#10](https://judge.softuni.bg/Contests/Practice/Index/154#10).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -331,7 +320,7 @@

#### Тестване в Judge системата

Тествайте решението си тук: [https://judge.softuni.bg/Contests/Practice/Index/510#11](https://judge.softuni.bg/Contests/Practice/Index/510#11).
Тествайте решението си тук: [https://judge.softuni.bg/Contests/Practice/Index/154#11](https://judge.softuni.bg/Contests/Practice/Index/154#11).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdamyanova
Copy link
Collaborator Author

Готова съм с линковете. Разгледах за squash commits, но не смея да пробвам, налага ли се, ще излизат ли комитите след като се мерджне?

@miglen
Copy link
Collaborator

miglen commented Jul 23, 2018

Не се страхувай от това, мисля че ще излезнат не е критично. Ако искаш да е safe, направи си нов branch от текущия за бекъп (git checkout -b chapter-05-loops-bkk) И след това си направи squash на всички промени в един. Препоръчвам и следното наименоване на отделните commits - https://chris.beams.io/posts/git-commit/
За мен не е голям проблем, просто е по-подредено.

@mdamyanova mdamyanova self-assigned this Oct 4, 2018
@vncpetrov vncpetrov merged commit 4912184 into master Oct 9, 2018
@nakov nakov deleted the chapter-05-loops branch June 21, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants