[UT] Add tests for C++ ThreadLocalUUIDGenerator #59267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfinus
force-pushed
the
refactor/cpp-uuidgenerator-tests
branch
2 times, most recently
from
c8066e2 to
02c2a45
Compare
24 tasks
|
Is there any docker image with environment for BE unit tests? I've tried to run UT on local machine, but I got compile errors for different libraries, and this is quite frustrating... |
Have you tried this docker image? |
dolfinus
force-pushed
the
refactor/cpp-uuidgenerator-tests
branch
2 times, most recently
from
38746ed to
53da1b8
Compare
dolfinus
force-pushed
the
refactor/cpp-uuidgenerator-tests
branch
2 times, most recently
from
d0ddfe8 to
eea8458
Compare
Signed-off-by: Martynov Maxim <[email protected]>
dolfinus
force-pushed
the
refactor/cpp-uuidgenerator-tests
branch
from
eea8458 to
7d941cd
Compare
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
alvin-celerdata
approved these changes
May 23, 2025
AntiTopQuark
pushed a commit
to AntiTopQuark/starrocks
that referenced
this pull request
Jun 19, 2025
Why I'm doing: Before changing behavior of ThreadLocalUUIDGenerator in StarRocks#59107, added some minimal tests. What I'm doing: Added tests for ThreadLocalUUIDGenerator C++ class, checking UUID uniqueness and thread-safety. Signed-off-by: Martynov Maxim <[email protected]> Signed-off-by: AntiTopQuark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Before changing behavior of
ThreadLocalUUIDGeneratorin #59107, added some minimal tests.What I'm doing:
Added tests for
ThreadLocalUUIDGeneratorC++ class, checking UUID uniqueness and thread-safety.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: