fix(react-query): fix to show type error on wrong type annotation in useQuery
#8683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skiende74
changed the title
skiende74
changed the title
skiende74
changed the title
skiende74
changed the title
useQuery
TkDodo
reviewed
Feb 28, 2025
packages/react-query/src/useQuery.ts
Outdated
|
|
||
| export function useQuery(options: UseQueryOptions, queryClient?: QueryClient) { | ||
| return useBaseQuery(options, QueryObserver, queryClient) | ||
| } | ||
|
|
||
| type NoInfer<T> = [T][T extends any ? 0 : never] |
There was a problem hiding this comment.
we already have a NoInfer util, you should be able to import it from the query-core package
|
Thanks for your review, @TkDodo! import { NoInfer } from 'query-core/util';Could you please take another look? |
|
View your CI Pipeline Execution ↗ for commit 568788e.
☁️ Nx Cloud last updated this comment at |
@skiende74 Resolve eslint error in /packages/react-query/src/tests/useQuery.test-d.tsx please |
|
@manudeli |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8683 +/- ##
===========================================
+ Coverage 44.53% 84.22% +39.68%
===========================================
Files 204 26 -178
Lines 8150 374 -7776
Branches 1820 111 -1709
===========================================
- Hits 3630 315 -3315
+ Misses 4077 50 -4027
+ Partials 443 9 -434
🚀 New features to boost your workflow:
|
TkDodo
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7530
This should produce a type error because the correct type for queryResult should be
UseQueryResult<string>.Previously, due to reverse type inference from the return type context, no error was detected when using the wrong type annotation.
This PR prevents reverse type inference from the result type annotation, ensuring that incorrect type annotations are caught as type errors.