Skip to content

Fix broken links in SSR documentation #8770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Conversation

sina-ss
Copy link
Contributor

@sina-ss sina-ss commented Mar 7, 2025

This PR fixes several broken links in the SSR documentation (ssr.md) that were preventing proper navigation between related concepts.

  • Fixed link to "prefetching" documentation
  • Fixed link to "request-waterfalls" documentation
  • Fixed link to "dependent-queries" documentation
  • Fixed section-specific link to "prefetching#dependent-queries--code-splitting"

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 7, 2025
@sina-ss
Copy link
Contributor Author

sina-ss commented Mar 7, 2025

This problem also exists in some other pages of the documentation. Write me a comment so I can add it to the pull request and fix other issues if needed.

@TkDodo
Copy link
Collaborator

TkDodo commented Mar 7, 2025

I remember ./ links didn’t work in the past for whatever reason. We’ll see after merging I guess

@TkDodo TkDodo merged commit d85ee75 into TanStack:main Mar 7, 2025
1 check passed
@TkDodo
Copy link
Collaborator

TkDodo commented Mar 8, 2025

yeah the links are still broken. They now go from:

https://tanstack.com/query/v5/docs/framework/react/guides/ssr

to:

https://tanstack.com/query/v5/docs/framework/react/guides/ssr/prefetching

which doesn’t exist.

I think what we want here is links to point to ../guides/prefetching to make it work.

DogPawHat pushed a commit to DogPawHat/query that referenced this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants