Skip to content

test(query-core): use fake timer for notifyManager.test.tsx #8773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 8, 2025
Merged

test(query-core): use fake timer for notifyManager.test.tsx #8773

merged 3 commits into from
Mar 8, 2025

Conversation

manudeli
Copy link
Collaborator

@manudeli manudeli commented Mar 8, 2025

No description provided.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 8, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 0bd4efb.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 5m 20s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 59s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-08 12:48:45 UTC

@TkDodo
Copy link
Collaborator

TkDodo commented Mar 8, 2025

thank you for all these PRs - they make our test pipeline faster and a lot more stable ❤️

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Mar 8, 2025 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8773

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8773

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8773

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8773

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8773

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8773

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8773

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8773

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8773

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8773

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8773

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8773

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8773

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8773

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8773

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8773

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8773

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8773

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8773

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8773

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8773

commit: 0bd4efb

@manudeli
Copy link
Collaborator Author

manudeli commented Mar 8, 2025

thank you for all these PRs - they make our test pipeline faster and a lot more stable ❤️

I'll do this until the end! Thanks for teaching me this way to test timer 🙇

@codecov Codecov
Copy link

codecov bot commented Mar 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.20%. Comparing base (8bfa77b) to head (0bd4efb).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8773       +/-   ##
===========================================
+ Coverage   46.39%   63.20%   +16.81%     
===========================================
  Files         199      135       -64     
  Lines        7551     4854     -2697     
  Branches     1728     1368      -360     
===========================================
- Hits         3503     3068      -435     
+ Misses       3668     1541     -2127     
+ Partials      380      245      -135
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 88.65% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 94.31% <ø> (-0.06%) ⬇️
@tanstack/query-devtools 4.78% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.42% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.20% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 87.33% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.01% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TkDodo TkDodo merged commit dcfc100 into TanStack:main Mar 8, 2025
6 of 7 checks passed
DogPawHat pushed a commit to DogPawHat/query that referenced this pull request Mar 12, 2025
@manudeli @DogPawHat
test(query-core): use fake timer for notifyManager.test.tsx (TanStack…
e936c50 
…#8773)

* test(query-core): use fake timer for notifyManager.test.tsx

* chore: update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: query-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manudeli @TkDodo