fix(examples, docs): ignored promise from invalidate queries

[keyurgovrani]

This PR fixes the issue of Promise returned from invalidateQueries being ignored in documentation and examples

[TkDodo]

the promise in the current code is not ignored:

onSettled: () => queryClient.invalidateQueries({ queryKey: ['todos'] }),

this code returns the promise from invalidateQueries, because arrow functions return the statement (if they have no brackets), and invalidateQueries returns a promise.

Wrapping this in return await is unnecessary.

[keyurgovrani]

Thank you @TkDodo for your feedback on my pull request. While it's true that arrow functions without braces return the result of their expression, I encountered issues with the code's behaviour, especially when arrow functions have curly braces. In those cases, an explicit return is required, and ESLint flagged warnings about the promise being ignored. This would ensure the promise is properly handled while maintaining both functionality and code quality. Could you please reconsider this approach and revisit the matter?

[TkDodo]

I encountered issues with the code's behaviour, especially when arrow functions have curly braces

yes because then you don’t return a Promise from the function. This is just how javascript works. You can return a Promise, or not. You can use arrow functions or not. You can write the same thing in a million ways

onSuccess: async () => { return await queryClient.invalidateQueries(...) }
onSuccess: () => queryClient.invalidateQueries(...)
onSuccess() { return queryClient.invalidateQueries(...) }
onSuccess: function onSuccess() { return queryClient.invalidateQueries(...) }

[nx-cloud]

View your CI Pipeline Execution ↗ for commit b8a3821.

Command	Status	Duration	Result
nx affected --targets=test:sherif,test:knip,tes...	✅ Succeeded	47s	View ↗
nx run-many --target=build --exclude=examples/*...	✅ Succeeded	2s	View ↗

---

☁️ Nx Cloud last updated this comment at 2025-03-26 09:27:54 UTC