Skip to content

fix(eslint): classic build #8971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

fix(eslint): classic build #8971

merged 1 commit into from
Apr 7, 2025

Conversation

Newbie012
Copy link
Collaborator

This PR ensures compatibility with classic (legacy) eslint plugin cjs build.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 7, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 4166c15.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 53s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 4s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-07 14:15:52 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 7, 2025

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8971

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8971

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8971

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8971

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8971

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8971

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8971

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8971

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8971

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8971

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8971

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8971

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8971

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8971

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8971

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8971

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8971

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8971

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8971

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8971

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8971

commit: 4166c15

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2025

Sizes for commit 4166c15:

Branch Bundle Size
Main
This PR

@codecov Codecov
Copy link

codecov bot commented Apr 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.19%. Comparing base (0e1d866) to head (4166c15).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8971       +/-   ##
===========================================
+ Coverage   44.30%   88.19%   +43.88%     
===========================================
  Files         202       16      -186     
  Lines        8058      542     -7516     
  Branches     1784      205     -1579     
===========================================
- Hits         3570      478     -3092     
+ Misses       4060       50     -4010     
+ Partials      428       14      -414
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query 88.19% <ø> (ø)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Newbie012 Newbie012 mentioned this pull request Apr 7, 2025
Closed
@Newbie012
Copy link
Collaborator Author

@TkDodo we should probably add a legacy config example which the CI should lint.

@TkDodo TkDodo merged commit 97c8d84 into main Apr 7, 2025
7 checks passed
@TkDodo TkDodo deleted the hotfix-eslint-cjs branch April 7, 2025 14:41
tylersayshi pushed a commit to tylersayshi/tanstack-query that referenced this pull request Apr 8, 2025
@Newbie012 @tylersayshi
fix(eslint): classic build (TanStack#8971)
ae0fd89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees
No one assigned
Labels
package: eslint-plugin-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Newbie012 @TkDodo