fix(eslint-plugin) separate legacy and modern dts files #8972
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "extends": ["plugin:@tanstack/query/recommended"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # See https://help.github.com/articles/ignoring-files/ for more about ignoring files. | ||
|
|
||
| # dependencies | ||
| /node_modules | ||
| /.pnp | ||
| .pnp.js | ||
|
|
||
| # testing | ||
| /coverage | ||
|
|
||
| # production | ||
| /build | ||
|
|
||
| pnpm-lock.yaml | ||
| yarn.lock | ||
| package-lock.json | ||
|
|
||
| # misc | ||
| .DS_Store | ||
| .env.local | ||
| .env.development.local | ||
| .env.test.local | ||
| .env.production.local | ||
|
|
||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # Example | ||
|
|
||
| To run this example: | ||
|
|
||
| - `npm install` | ||
| - `npm run dev` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <link rel="shortcut icon" type="image/svg+xml" href="/emblem-light.svg" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <meta name="theme-color" content="#000000" /> | ||
|
|
||
| <title>TanStack Query React Basic Example App</title> | ||
| </head> | ||
| <body> | ||
| <noscript>You need to enable JavaScript to run this app.</noscript> | ||
| <div id="root"></div> | ||
| <script type="module" src="/src/index.tsx"></script> | ||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| { | ||
| "name": "@tanstack/query-example-eslint-legacy", | ||
| "private": true, | ||
| "type": "module", | ||
| "scripts": { | ||
| "dev": "vite", | ||
| "build": "vite build", | ||
| "preview": "vite preview", | ||
| "test:eslint": "eslint ./src" | ||
| }, | ||
| "dependencies": { | ||
| "@tanstack/query-sync-storage-persister": "^5.72.0", | ||
| "@tanstack/react-query": "^5.72.0", | ||
| "@tanstack/react-query-devtools": "^5.72.0", | ||
| "@tanstack/react-query-persist-client": "^5.72.0", | ||
| "react": "^19.0.0", | ||
| "react-dom": "^19.0.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@tanstack/eslint-plugin-query": "^5.72.0", | ||
| "eslint": "^8.16.0", | ||
| "@types/react": "^18.2.79", | ||
| "@types/react-dom": "^18.2.25", | ||
| "@vitejs/plugin-react": "^4.3.4", | ||
| "typescript": "5.8.2", | ||
| "vite": "^6.2.4" | ||
| } | ||
| } | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,161 @@ | ||
| import * as React from 'react' | ||
| import ReactDOM from 'react-dom/client' | ||
| import { QueryClient, useQuery, useQueryClient } from '@tanstack/react-query' | ||
| import { PersistQueryClientProvider } from '@tanstack/react-query-persist-client' | ||
| import { createSyncStoragePersister } from '@tanstack/query-sync-storage-persister' | ||
| import { ReactQueryDevtools } from '@tanstack/react-query-devtools' | ||
|
|
||
| const queryClient = new QueryClient({ | ||
| defaultOptions: { | ||
| queries: { | ||
| gcTime: 1000 * 60 * 60 * 24, // 24 hours | ||
| }, | ||
| }, | ||
| }) | ||
|
|
||
| const persister = createSyncStoragePersister({ | ||
| storage: window.localStorage, | ||
| }) | ||
|
|
||
| type Post = { | ||
| id: number | ||
| title: string | ||
| body: string | ||
| } | ||
|
|
||
| function usePosts() { | ||
| return useQuery({ | ||
| queryKey: ['posts'], | ||
| queryFn: async (): Promise<Array<Post>> => { | ||
| const response = await fetch('https://jsonplaceholder.typicode.com/posts') | ||
| return await response.json() | ||
| }, | ||
| }) | ||
| } | ||
|
|
||
| function Posts({ | ||
| setPostId, | ||
| }: { | ||
| setPostId: React.Dispatch<React.SetStateAction<number>> | ||
| }) { | ||
| const queryClient = useQueryClient() | ||
| const { status, data, error, isFetching } = usePosts() | ||
|
|
||
| return ( | ||
| <div> | ||
| <h1>Posts</h1> | ||
| <div> | ||
| {status === 'pending' ? ( | ||
| 'Loading...' | ||
| ) : status === 'error' ? ( | ||
| <span>Error: {error.message}</span> | ||
| ) : ( | ||
| <> | ||
| <div> | ||
| {data.map((post) => ( | ||
| <p key={post.id}> | ||
| <a | ||
| onClick={() => setPostId(post.id)} | ||
| href="#" | ||
| style={ | ||
| // We can access the query data here to show bold links for | ||
| // ones that are cached | ||
| queryClient.getQueryData(['post', post.id]) | ||
| ? { | ||
| fontWeight: 'bold', | ||
| color: 'green', | ||
| } | ||
| : {} | ||
| } | ||
| > | ||
| {post.title} | ||
| </a> | ||
| </p> | ||
| ))} | ||
| </div> | ||
| <div>{isFetching ? 'Background Updating...' : ' '}</div> | ||
| </> | ||
| )} | ||
| </div> | ||
| </div> | ||
| ) | ||
| } | ||
|
|
||
| const getPostById = async (id: number): Promise<Post> => { | ||
| const response = await fetch( | ||
| `https://jsonplaceholder.typicode.com/posts/${id}`, | ||
| ) | ||
| return await response.json() | ||
| } | ||
|
|
||
| function usePost(postId: number) { | ||
| return useQuery({ | ||
| queryKey: ['post', postId], | ||
| queryFn: () => getPostById(postId), | ||
| enabled: !!postId, | ||
| }) | ||
| } | ||
|
|
||
| function Post({ | ||
| postId, | ||
| setPostId, | ||
| }: { | ||
| postId: number | ||
| setPostId: React.Dispatch<React.SetStateAction<number>> | ||
| }) { | ||
| const { status, data, error, isFetching } = usePost(postId) | ||
|
|
||
| return ( | ||
| <div> | ||
| <div> | ||
| <a onClick={() => setPostId(-1)} href="#"> | ||
| Back | ||
| </a> | ||
| </div> | ||
| {!postId || status === 'pending' ? ( | ||
| 'Loading...' | ||
| ) : status === 'error' ? ( | ||
| <span>Error: {error.message}</span> | ||
| ) : ( | ||
| <> | ||
| <h1>{data.title}</h1> | ||
| <div> | ||
| <p>{data.body}</p> | ||
| </div> | ||
| <div>{isFetching ? 'Background Updating...' : ' '}</div> | ||
| </> | ||
| )} | ||
| </div> | ||
| ) | ||
| } | ||
|
|
||
| function App() { | ||
| const [postId, setPostId] = React.useState(-1) | ||
|
|
||
| return ( | ||
| <PersistQueryClientProvider | ||
| client={queryClient} | ||
| persistOptions={{ persister }} | ||
| > | ||
| <p> | ||
| As you visit the posts below, you will notice them in a loading state | ||
| the first time you load them. However, after you return to this list and | ||
| click on any posts you have already visited again, you will see them | ||
| load instantly and background refresh right before your eyes!{' '} | ||
| <strong> | ||
| (You may need to throttle your network speed to simulate longer | ||
| loading sequences) | ||
| </strong> | ||
| </p> | ||
| {postId > -1 ? ( | ||
| <Post postId={postId} setPostId={setPostId} /> | ||
| ) : ( | ||
| <Posts setPostId={setPostId} /> | ||
| )} | ||
| <ReactQueryDevtools initialIsOpen /> | ||
| </PersistQueryClientProvider> | ||
| ) | ||
| } | ||
|
|
||
| const rootElement = document.getElementById('root') as HTMLElement | ||
| ReactDOM.createRoot(rootElement).render(<App />) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "target": "ES2020", | ||
| "useDefineForClassFields": true, | ||
| "lib": ["ES2020", "DOM", "DOM.Iterable"], | ||
| "module": "ESNext", | ||
| "skipLibCheck": true, | ||
|
|
||
| /* Bundler mode */ | ||
| "moduleResolution": "Bundler", | ||
| "allowImportingTsExtensions": true, | ||
| "resolveJsonModule": true, | ||
| "isolatedModules": true, | ||
| "noEmit": true, | ||
| "jsx": "react-jsx", | ||
|
|
||
| /* Linting */ | ||
| "strict": true, | ||
| "noUnusedLocals": true, | ||
| "noUnusedParameters": true, | ||
| "noFallthroughCasesInSwitch": true | ||
| }, | ||
| "include": ["src", "eslint.config.js"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import { defineConfig } from 'vite' | ||
| import react from '@vitejs/plugin-react' | ||
|
|
||
| export default defineConfig({ | ||
| plugins: [react()], | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want this example to be lintend in CI, you need to add a
test:eslintscript and we’ll have to remove the--excludehere:query/package.json
Line 16 in 7e4e2e6
Not sure why examples were excluded, most of them don’t have that task specified anyways 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, but it seems like something is off with packages that I didn't touch 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah sadly, some tests are flaky. I’ll ship it