Skip to content

chore: use "moduleResolution": "Bundler" at root level #9002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 12, 2025
Merged

chore: use "moduleResolution": "Bundler" at root level #9002

merged 6 commits into from
Apr 12, 2025

Conversation

lachlancollins
Copy link
Member

Since there were previously tests for TS versions pre-5.0, the root tsconfig couldn't use "moduleResolution": "Bundler", as these versions wouldn't recognise this option. Now that tests are all 5.0+, we can simplify the workspace config.

@lachlancollins lachlancollins changed the title chore: use "moduleResolution": "Bundler" at workspace level chore: use "moduleResolution": "Bundler" at root level Apr 12, 2025
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 12, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 25e209b.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ❌ Failed 3m 25s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 5s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-12 00:59:54 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 12, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9002

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9002

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9002

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9002

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9002

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9002

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9002

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9002

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9002

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9002

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9002

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9002

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9002

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9002

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9002

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9002

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9002

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9002

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9002

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9002

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9002

commit: 25e209b

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 12, 2025 •
edited
Loading

Sizes for commit 25e209b:

Branch Bundle Size
Main
This PR

@lachlancollins lachlancollins merged commit c4afce4 into main Apr 12, 2025
4 of 5 checks passed
@lachlancollins lachlancollins deleted the workspace-changes branch April 12, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: angular-query-devtools-experimental package: angular-query-experimental package: eslint-plugin-query package: query-async-storage-persister package: query-broadcast-client-experimental package: query-codemods package: query-core package: query-devtools package: query-persist-client-core package: query-sync-storage-persister package: react-query package: react-query-devtools package: react-query-next-experimental package: react-query-persist-client package: solid-query package: solid-query-devtools package: solid-query-persist-client package: svelte-query package: svelte-query-devtools package: svelte-query-persist-client package: vue-query package: vue-query-devtools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lachlancollins