test(query-core): use fake timers for hydration.test.tsx #9006

manudeli · 2025-04-12T09:10:44Z

No description provided.

nx-cloud · 2025-04-12T09:11:12Z

View your CI Pipeline Execution ↗ for commit 25fcb6d.

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	5m 36s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2m 2s	View ↗

☁️ Nx Cloud last updated this comment at 2025-04-12 16:32:41 UTC

pkg-pr-new · 2025-04-12T09:14:13Z

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9006

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9006

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9006

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9006

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9006

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9006

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9006

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9006

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9006

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9006

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9006

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9006

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9006

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9006

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9006

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9006

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9006

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9006

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9006

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9006

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9006

commit: 25fcb6d

codecov · 2025-04-12T09:17:15Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.54%. Comparing base (38178ba) to head (25fcb6d).
Report is 4 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #9006       +/-   ##
===========================================
+ Coverage   44.18%   58.54%   +14.35%     
===========================================
  Files         202      137       -65     
  Lines        8063     5317     -2746     
  Branches     1775     1398      -377     
===========================================
- Hits         3563     3113      -450     
+ Misses       4068     1915     -2153     
+ Partials      432      289      -143

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`88.08% <ø> (ø)`
@tanstack/eslint-plugin-query	`∅ <ø> (∅)`
@tanstack/query-async-storage-persister	`43.85% <ø> (ø)`
@tanstack/query-broadcast-client-experimental	`∅ <ø> (∅)`
@tanstack/query-codemods	`∅ <ø> (∅)`
@tanstack/query-core	`94.82% <ø> (ø)`
@tanstack/query-devtools	`3.61% <ø> (ø)`
@tanstack/query-persist-client-core	`73.46% <ø> (ø)`
@tanstack/query-sync-storage-persister	`84.61% <ø> (ø)`
@tanstack/react-query	`95.42% <ø> (ø)`
@tanstack/react-query-devtools	`10.00% <ø> (ø)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`100.00% <ø> (ø)`
@tanstack/solid-query	`78.48% <ø> (ø)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`100.00% <ø> (ø)`
@tanstack/svelte-query	`88.15% <ø> (ø)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`100.00% <ø> (ø)`
@tanstack/vue-query	`71.01% <ø> (ø)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ion.test.tsx

TkDodo · 2025-04-23T08:13:36Z

@manudeli useMutationState in react-query is a flaky test that I think would benefit most from updating to fake timers. Any chance you can take a stab at that?

Oh, and if you are on Discord, please reach out to me (TkDodo) 🙏

manudeli · 2025-04-23T08:17:08Z

@manudeli useMutationState in react-query is a flaky test that I think would benefit most from updating to fake timers. Any chance you can take a stab at that?

Sure, I'll do that 👍

manudeli · 2025-04-23T08:34:08Z

Oh, and if you are on Discord, please reach out to me (TkDodo) 🙏

@TkDodo, I just sent you DM on Discord 🙂

test(query-core): use fake timers for hydration.test.tsx

23ad402

github-actions bot added the package: query-core label Apr 12, 2025

Merge branch 'main' into query-core/query-core/use-fake-timers-hydrat…

25fcb6d

…ion.test.tsx

TkDodo merged commit 403ebd4 into TanStack:main Apr 12, 2025
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(query-core): use fake timers for hydration.test.tsx #9006

test(query-core): use fake timers for hydration.test.tsx #9006

manudeli commented Apr 12, 2025

nx-cloud bot commented Apr 12, 2025 •

edited

Loading

pkg-pr-new bot commented Apr 12, 2025 •

edited

Loading

codecov bot commented Apr 12, 2025 •

edited

Loading

TkDodo commented Apr 23, 2025

manudeli commented Apr 23, 2025

manudeli commented Apr 23, 2025

test(query-core): use fake timers for hydration.test.tsx #9006

test(query-core): use fake timers for hydration.test.tsx #9006

Conversation

manudeli commented Apr 12, 2025

nx-cloud bot commented Apr 12, 2025 • edited Loading

pkg-pr-new bot commented Apr 12, 2025 • edited Loading

codecov bot commented Apr 12, 2025 • edited Loading

Codecov Report

TkDodo commented Apr 23, 2025

manudeli commented Apr 23, 2025

manudeli commented Apr 23, 2025

nx-cloud bot commented Apr 12, 2025 •

edited

Loading

pkg-pr-new bot commented Apr 12, 2025 •

edited

Loading

codecov bot commented Apr 12, 2025 •

edited

Loading