Skip to content

fix(query-core): make sure we don't invoke select too often when using placeholderData #9007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 12, 2025
Merged

fix(query-core): make sure we don't invoke select too often when using placeholderData #9007

merged 6 commits into from
Apr 12, 2025

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Apr 12, 2025

No description provided.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 12, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 0149f52.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 37s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 27s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-12 14:19:13 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 12, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9007

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9007

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9007

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9007

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9007

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9007

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9007

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9007

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9007

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9007

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9007

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9007

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9007

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9007

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9007

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9007

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9007

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9007

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9007

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9007

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9007

commit: 0149f52

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 12, 2025 •
edited
Loading

Sizes for commit 0149f52:

Branch Bundle Size
Main
This PR

@codecov Codecov
Copy link

codecov bot commented Apr 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.81%. Comparing base (d5ba5d1) to head (0149f52).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9007       +/-   ##
===========================================
+ Coverage   44.55%   60.81%   +16.26%     
===========================================
  Files         202      153       -49     
  Lines        8067     5859     -2208     
  Branches     1780     1596      -184     
===========================================
- Hits         3594     3563       -31     
+ Misses       4049     1985     -2064     
+ Partials      424      311      -113
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 88.08% <ø> (ø)
@tanstack/eslint-plugin-query 83.02% <ø> (-5.17%) ⬇️
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 94.82% <100.00%> (+0.04%) ⬆️
@tanstack/query-devtools 3.61% <ø> (ø)
@tanstack/query-persist-client-core 73.46% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.42% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.48% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 88.15% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.01% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TkDodo
ref: run through placeholderData first, then through
d3674b7 
this helps us memoizing select calls, and we can get rid of some duplication around how select is called again after placeholderData
TkDodo
TkDodo commented Apr 12, 2025
View reviewed changes
packages/query-core/src/__tests__/queryObserver.test.tsx
Comment on lines -956 to -957
// @ts-expect-error
select: () => undefined,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this test was quite weird to begin with because it’s not allowed to return undefined from select 🤷

@TkDodo TkDodo merged commit 38178ba into main Apr 12, 2025
7 checks passed
@TkDodo TkDodo deleted the feature/select-placeholderData branch April 12, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: eslint-plugin-query package: query-core package: vue-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TkDodo