Skip to content

Issue #7487 fix: (query-broadcast-client-experimental) - removing query from one tab doesn't remove it from all tabs #9017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 4, 2025
Merged

Issue #7487 fix: (query-broadcast-client-experimental) - removing query from one tab doesn't remove it from all tabs #9017

merged 6 commits into from
May 4, 2025

Conversation

gopnik5
Copy link
Contributor

@gopnik5 gopnik5 commented Apr 14, 2025

Issue #7487 fix: (query-broadcast-client-experimental) - removing query from one tab doesn't remove it from all tabs

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 4, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 955150b.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 9s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 6s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-04 08:07:33 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 4, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9017

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9017

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9017

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9017

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9017

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9017

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9017

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9017

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9017

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9017

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9017

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9017

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9017

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9017

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9017

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9017

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9017

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9017

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9017

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9017

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9017

commit: 955150b

TkDodo
TkDodo reviewed May 4, 2025
View reviewed changes
Copy link
Collaborator

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add a vite config to make the test errors go away. Have a look at the react-query package how it’s done there.

@TkDodo
Copy link
Collaborator

TkDodo commented May 4, 2025

I did that here: 955150b

@codecov Codecov
Copy link

codecov bot commented May 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 44.50%. Comparing base (18af643) to head (955150b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9017      +/-   ##
==========================================
- Coverage   44.60%   44.50%   -0.11%     
==========================================
  Files         203      204       +1     
  Lines        8107     8148      +41     
  Branches     1804     1824      +20     
==========================================
+ Hits         3616     3626      +10     
- Misses       4059     4079      +20     
- Partials      432      443      +11
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 85.23% <ø> (ø)
@tanstack/eslint-plugin-query 83.02% <ø> (ø)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental 24.39% <33.33%> (∅)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core 95.96% <ø> (ø)
@tanstack/query-devtools 3.61% <ø> (ø)
@tanstack/query-persist-client-core 73.46% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.42% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.48% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 88.15% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.10% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TkDodo TkDodo merged commit 674f83e into TanStack:main May 4, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees
No one assigned
Labels
package: query-broadcast-client-experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gopnik5 @TkDodo