fix(query-core, vue-query): fix type inference in `setQueryData` when used in functions with explicit return types #9030

custardcream98 · 2025-04-16T03:08:55Z

Applied the NoInfer utility type to the return type of setQueryData to prevent the outer function's return type from affecting the updater function's type inference.

closes #9024

…nctions

nx-cloud · 2025-04-16T03:09:20Z

View your CI Pipeline Execution ↗ for commit 7c34847.

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	3m 42s	View ↗

☁️ Nx Cloud last updated this comment at 2025-04-17 09:05:04 UTC

…ctions

pkg-pr-new · 2025-04-16T03:24:25Z

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9030

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9030

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9030

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9030

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9030

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9030

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9030

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9030

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9030

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9030

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9030

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9030

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9030

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9030

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9030

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9030

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9030

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9030

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9030

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9030

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9030

commit: 7c34847

custardcream98 · 2025-04-16T04:53:25Z

The CI test failure seems unrelated to the changes in this PR. My changes only affect TypeScript type definitions and a type test, with no runtime behavior modifications. The failure appears to be in an unrelated test.

codecov · 2025-04-17T09:05:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.02%. Comparing base (4a5990e) to head (7c34847).
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #9030       +/-   ##
===========================================
+ Coverage   44.58%   59.02%   +14.44%     
===========================================
  Files         203      138       -65     
  Lines        8106     5360     -2746     
  Branches     1801     1426      -375     
===========================================
- Hits         3614     3164      -450     
+ Misses       4060     1907     -2153     
+ Partials      432      289      -143

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`85.23% <ø> (ø)`
@tanstack/eslint-plugin-query	`∅ <ø> (∅)`
@tanstack/query-async-storage-persister	`43.85% <ø> (ø)`
@tanstack/query-broadcast-client-experimental	`∅ <ø> (∅)`
@tanstack/query-codemods	`∅ <ø> (∅)`
@tanstack/query-core	`95.95% <100.00%> (ø)`
@tanstack/query-devtools	`3.61% <ø> (ø)`
@tanstack/query-persist-client-core	`73.46% <ø> (ø)`
@tanstack/query-sync-storage-persister	`84.61% <ø> (ø)`
@tanstack/react-query	`95.42% <ø> (ø)`
@tanstack/react-query-devtools	`10.00% <ø> (ø)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`100.00% <ø> (ø)`
@tanstack/solid-query	`78.48% <ø> (ø)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`100.00% <ø> (ø)`
@tanstack/svelte-query	`88.15% <ø> (ø)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`100.00% <ø> (ø)`
@tanstack/vue-query	`71.01% <100.00%> (ø)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

custardcream98 added 2 commits April 16, 2025 11:53

fix(query-core): fix setQueryData type inference in typed contexts

775d072

test(query-core): add test case for setQueryData type inference in fu…

53a2d79

…nctions

github-actions bot added the package: query-core label Apr 16, 2025

fix(vue-query): fix setQueryData type inference in typed contexts

b5c6dde

github-actions bot added the package: vue-query label Apr 16, 2025

test(vue-query): add test case for setQueryData type inference in fun…

7c34847

…ctions

custardcream98 force-pushed the fix/preserve-set-query-data-type-inference branch from a164952 to 7c34847 Compare April 16, 2025 03:20

custardcream98 changed the title ~~fix(query-core): fix type inference in setQueryData when used in functions with explicit return types~~ fix(query-core, vue-query): fix type inference in setQueryData when used in functions with explicit return types Apr 16, 2025

TkDodo approved these changes Apr 17, 2025

View reviewed changes

TkDodo merged commit 8f8e6d0 into TanStack:main Apr 17, 2025
8 of 9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(query-core, vue-query): fix type inference in `setQueryData` when used in functions with explicit return types #9030

fix(query-core, vue-query): fix type inference in `setQueryData` when used in functions with explicit return types #9030

custardcream98 commented Apr 16, 2025

nx-cloud bot commented Apr 16, 2025 •

edited

Loading

pkg-pr-new bot commented Apr 16, 2025

custardcream98 commented Apr 16, 2025

codecov bot commented Apr 17, 2025 •

edited

Loading

fix(query-core, vue-query): fix type inference in setQueryData when used in functions with explicit return types #9030

fix(query-core, vue-query): fix type inference in setQueryData when used in functions with explicit return types #9030

Conversation

custardcream98 commented Apr 16, 2025

nx-cloud bot commented Apr 16, 2025 • edited Loading

pkg-pr-new bot commented Apr 16, 2025

custardcream98 commented Apr 16, 2025

codecov bot commented Apr 17, 2025 • edited Loading

Codecov Report

fix(query-core, vue-query): fix type inference in `setQueryData` when used in functions with explicit return types #9030

fix(query-core, vue-query): fix type inference in `setQueryData` when used in functions with explicit return types #9030

nx-cloud bot commented Apr 16, 2025 •

edited

Loading

codecov bot commented Apr 17, 2025 •

edited

Loading