Skip to content

fix(vue-query): unify shallow flag behaviour #9050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

fix(vue-query): unify shallow flag behaviour #9050

merged 1 commit into from
Apr 22, 2025

Conversation

DamianOsipiuk
Copy link
Contributor

@DamianOsipiuk DamianOsipiuk commented Apr 22, 2025 •
edited
Loading

Closes: #8055

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 22, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 9aec6be.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 39s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 22s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-22 17:02:29 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 22, 2025

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9050

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9050

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9050

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9050

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9050

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9050

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9050

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9050

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9050

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9050

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9050

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9050

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9050

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9050

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9050

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9050

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9050

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9050

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9050

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9050

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9050

commit: 9aec6be

@github-actions GitHub Actions
Copy link

Sizes for commit 9aec6be:

Branch Bundle Size
Main
This PR

@DamianOsipiuk DamianOsipiuk merged commit 3a2e2d9 into main Apr 22, 2025
5 checks passed
@DamianOsipiuk DamianOsipiuk deleted the do/respect-shallow-setting branch April 22, 2025 17:03
@codecov Codecov
Copy link

codecov bot commented Apr 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 71.10%. Comparing base (b63a1d0) to head (9aec6be).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9050       +/-   ##
===========================================
+ Coverage   44.58%   71.10%   +26.51%     
===========================================
  Files         203       19      -184     
  Lines        8106      481     -7625     
  Branches     1802      136     -1666     
===========================================
- Hits         3614      342     -3272     
+ Misses       4060      109     -3951     
+ Partials      432       30      -402
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query 71.10% <66.66%> (+0.08%) ⬆️
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: vue-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[vue-query] shallow: false can lead to identity hazards
1 participant
@DamianOsipiuk