Skip to content

test(query-persist-client-core): use fake timers for createPersister.test.ts #9067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 26, 2025
Merged

test(query-persist-client-core): use fake timers for createPersister.test.ts #9067

merged 3 commits into from
Apr 26, 2025

Conversation

minseong0324
Copy link
Contributor

No description provided.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 25, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit fe6b455.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 4m 26s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 56s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-26 10:25:23 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 25, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9067

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9067

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9067

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9067

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9067

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9067

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9067

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9067

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9067

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9067

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9067

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9067

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9067

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9067

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9067

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9067

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9067

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9067

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9067

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9067

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9067

commit: fe6b455

@codecov Codecov
Copy link

codecov bot commented Apr 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.44%. Comparing base (62f02fc) to head (fe6b455).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9067       +/-   ##
===========================================
+ Coverage   44.58%   80.44%   +35.86%     
===========================================
  Files         203       37      -166     
  Lines        8104      629     -7475     
  Branches     1801      166     -1635     
===========================================
- Hits         3613      506     -3107     
+ Misses       4059      108     -3951     
+ Partials      432       15      -417
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core 73.46% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.42% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@manudeli manudeli self-requested a review April 26, 2025 10:18
manudeli
manudeli approved these changes Apr 26, 2025
View reviewed changes
Copy link
Collaborator

@manudeli manudeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@manudeli manudeli merged commit 83f01cd into TanStack:main Apr 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manudeli manudeli manudeli approved these changes

Assignees
No one assigned
Labels
package: query-persist-client-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minseong0324 @manudeli