Skip to content

test(solid-query): use fake timers for useMutation.test.tsx #9081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

test(solid-query): use fake timers for useMutation.test.tsx #9081

merged 1 commit into from
Apr 29, 2025

Conversation

manudeli
Copy link
Collaborator

@manudeli manudeli commented Apr 29, 2025 •
edited
Loading

No description provided.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 29, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 7a77af9.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 53s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 12s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-29 14:00:19 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 29, 2025

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9081

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9081

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9081

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9081

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9081

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9081

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9081

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9081

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9081

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9081

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9081

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9081

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9081

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9081

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9081

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9081

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9081

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9081

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9081

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9081

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9081

commit: 7a77af9

manudeli
manudeli commented Apr 29, 2025
View reviewed changes
packages/solid-query/src/__tests__/useMutation.test.tsx
@@ -351,7 +355,7 @@ describe('useMutation', () => {
</QueryClientProvider>
))

await sleep(100)
await vi.advanceTimersByTimeAsync(10)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly but not flaky

packages/solid-query/src/__tests__/useMutation.test.tsx
@@ -404,7 +408,7 @@ describe('useMutation', () => {
</QueryClientProvider>
))

await sleep(100)
await vi.advanceTimersByTimeAsync(10)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly but not flaky

packages/solid-query/src/__tests__/useMutation.test.tsx
@@ -452,7 +453,7 @@ describe('useMutation', () => {
</QueryClientProvider>
))

await sleep(100)
await vi.advanceTimersByTimeAsync(20)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly but not flaky

packages/solid-query/src/__tests__/useMutation.test.tsx
@@ -489,7 +490,7 @@ describe('useMutation', () => {
</QueryClientProvider>
))

await sleep(100)
await vi.advanceTimersByTimeAsync(20)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly but not flaky

@codecov Codecov
Copy link

codecov bot commented Apr 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.76%. Comparing base (10493ef) to head (7a77af9).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9081       +/-   ##
===========================================
+ Coverage   44.56%   79.76%   +35.19%     
===========================================
  Files         203       16      -187     
  Lines        8101      336     -7765     
  Branches     1809       63     -1746     
===========================================
- Hits         3610      268     -3342     
+ Misses       4059       56     -4003     
+ Partials      432       12      -420
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query 78.48% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@manudeli manudeli marked this pull request as ready for review April 29, 2025 14:05
@manudeli manudeli merged commit eb5816e into TanStack:main Apr 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: solid-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@manudeli