Skip to content

test(react-query): use fake timers for useQuery.test.tsx #9086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 1, 2025
Merged

test(react-query): use fake timers for useQuery.test.tsx #9086

merged 3 commits into from
May 1, 2025

Conversation

manudeli
Copy link
Collaborator

No description provided.

@manudeli manudeli assigned manudeli and unassigned manudeli Apr 29, 2025
@manudeli manudeli requested a review from Copilot April 29, 2025 16:43
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 29, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 494564e.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 46s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 34s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-01 16:40:25 UTC

Copilot
Copilot AI reviewed Apr 29, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 29, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9086

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9086

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9086

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9086

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9086

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9086

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9086

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9086

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9086

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9086

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9086

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9086

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9086

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9086

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9086

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9086

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9086

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9086

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9086

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9086

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9086

commit: 494564e

@codecov Codecov
Copy link

codecov bot commented Apr 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.22%. Comparing base (fd34b98) to head (494564e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9086       +/-   ##
===========================================
+ Coverage   44.60%   84.22%   +39.62%     
===========================================
  Files         203       26      -177     
  Lines        8107      374     -7733     
  Branches     1815      110     -1705     
===========================================
- Hits         3616      315     -3301     
+ Misses       4059       50     -4009     
+ Partials      432        9      -423
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query 95.42% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@manudeli manudeli marked this pull request as ready for review April 30, 2025 00:49
@manudeli manudeli requested a review from TkDodo April 30, 2025 01:30
@manudeli
Copy link
Collaborator Author

@TkDodo This Pull Request changes test code for important interface, useQuery, so I'd like to request your review

@manudeli
Copy link
Collaborator Author

manudeli commented May 1, 2025

@TkDodo This Pull Request changes test code for important interface, useQuery, so I'd like to request your review

I reviewed this pull request again and didn't find any issues, so I merge it now.

@manudeli manudeli merged commit df8e02b into TanStack:main May 1, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@TkDodo TkDodo Awaiting requested review from TkDodo

Assignees
No one assigned
Labels
package: react-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@manudeli